Merged
Conversation
jmarrec
added
Pull Request - Ready for CI
… has an issue on armv8 apple clang17 NatLabRockies/OpenStudio@8fcda7e
jmarrec
force-pushed
the
bump_os_sdk_3110_rc1
branch
2 times, most recently
from
1d3dc43 to
5c5abdc
Compare
Collaborator
Author
|
macos-13 is now fully removed, but that's convenient to leave it like this since the OS SDK is missing x64 mac insallers anyways. Not going to update the workflow to macos-15-intel now |
Collaborator
Author
|
Ok CI looks good! @macumber wanna do a quick review before I merge? |
macumber
reviewed
Dec 9, 2025
macumber
reviewed
Dec 9, 2025
| set(OPENSTUDIO_EXPECTED_HASH 389a02d7f9d3526454bca74393ac7a6e) | ||
| else() | ||
| set(OPENSTUDIO_EXPECTED_HASH 00d0321aa6c4ab5a3c36fe2335a07157) | ||
| set(OPENSTUDIO_EXPECTED_HASH TODO_MISSING_TODO) # There is no mac intel (x86_64) installer |
Collaborator
There was a problem hiding this comment.
Will there be a Mac x86 installer or is this the end for that platform?
Collaborator
Author
There was a problem hiding this comment.
I am hoping there will be one, but not sure.
macumber
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singleton<>template since that got removed on OS SDK as well. Replaced with a Meyers singleton.